add assembly to gcompose, not working yet

src/Math/Assembly.cpp

@@ -25,7 +25,9 @@ Assembly::Assembly()
       m_BBoxMin(Vector3f::Zero()),
       m_BBoxMax(Vector3f::Zero()),
       m_ShowBoundingBox(false),
-      m_GroupSelection(true) {}
+      m_GroupSelection(true) {
+    ULIB_ACTIVATE_PROPERTIES(*this);
+}
 
 Assembly::Assembly(const Assembly &copy)
     : ObjectsContext(copy),
@@ -35,13 +37,25 @@ Assembly::Assembly(const Assembly &copy)
       m_ShowBoundingBox(copy.m_ShowBoundingBox),
       m_GroupSelection(copy.m_GroupSelection) {}
 
-Assembly::~Assembly() {}
+Assembly::~Assembly() {
+    for (auto const& [obj, conn] : m_ChildConnections) {
+        conn.disconnect();
+    }
+    m_ChildConnections.clear();
+}
 
 void Assembly::AddObject(Object *obj) {
     if (auto *at = dynamic_cast<AffineTransform *>(obj)) {
         at->SetParent(this);
     }
     ObjectsContext::AddObject(obj);
+    
+    // Connect to child updates to recompute AABB
+    m_ChildConnections[obj] = Object::connect(obj, &Object::Updated, [this](){
+        this->ComputeBoundingBox();
+        this->Updated(); // Signal that assembly itself changed (AABB-wise)
+    });
+    this->ComputeBoundingBox();
 }
 
 void Assembly::RemoveObject(Object *obj) {
@@ -49,7 +63,15 @@ void Assembly::RemoveObject(Object *obj) {
         if (at->GetParent() == this)
             at->SetParent(nullptr);
     }
+    
+    auto itConn = m_ChildConnections.find(obj);
+    if (itConn != m_ChildConnections.end()) {
+        itConn->second.disconnect();
+        m_ChildConnections.erase(itConn);
+    }
+    
     ObjectsContext::RemoveObject(obj);
+    this->ComputeBoundingBox();
 }
 
 void Assembly::ComputeBoundingBox() {
@@ -64,12 +86,11 @@ void Assembly::ComputeBoundingBox() {
     m_BBoxMin = Vector3f(inf, inf, inf);
     m_BBoxMax = Vector3f(-inf, -inf, -inf);
 
-    Matrix4f invAsm = this->GetWorldMatrix().inverse();
-
     for (Object *obj : objects) {
         if (auto *box = dynamic_cast<ContainerBox *>(obj)) {
-            // ContainerBox: wm is matrix from unit cube [0,1] to assembly base
-            Matrix4f m = invAsm * box->GetWorldMatrix();
+            // ContainerBox: wm is matrix from unit cube [0,1] to local space
+            // Since it is parented to 'this', GetMatrix() is sufficient.
+            Matrix4f m = box->GetMatrix();
             for (int i = 0; i < 8; ++i) {
                 float x = (i & 1) ? 1.0f : 0.0f;
                 float y = (i & 2) ? 1.0f : 0.0f;
@@ -82,7 +103,7 @@ void Assembly::ComputeBoundingBox() {
             }
         } else if (auto *cyl = dynamic_cast<Cylinder *>(obj)) {
             // Cylinder: centered [-1, 1] radial, [-0.5, 0.5] height
-            Matrix4f m = invAsm * cyl->GetWorldMatrix();
+            Matrix4f m = cyl->GetMatrix();
             for (int i = 0; i < 8; ++i) {
                 float x = (i & 1) ? 1.0f : -1.0f;
                 float y = (i & 2) ? 0.5f : -0.5f;
@@ -98,7 +119,7 @@ void Assembly::ComputeBoundingBox() {
             subAsm->ComputeBoundingBox();
             Vector3f subMin, subMax;
             subAsm->GetBoundingBox(subMin, subMax);
-            Matrix4f m = invAsm * subAsm->GetWorldMatrix();
+            Matrix4f m = subAsm->GetMatrix();
             for (int i = 0; i < 8; ++i) {
                 float x = (i & 1) ? subMax(0) : subMin(0);
                 float y = (i & 2) ? subMax(1) : subMin(1);

src/Math/Assembly.h

@@ -52,6 +52,12 @@ public:
     Assembly(const Assembly &copy);
     virtual ~Assembly();
 
+    template <class ArchiveT>
+    void serialize(ArchiveT & ar, const unsigned int version) {
+        ar & boost::serialization::make_nvp("AffineTransform", boost::serialization::base_object<AffineTransform>(*this));
+        ar & boost::serialization::make_hrp("GroupSelection", m_GroupSelection);
+    }
+
     virtual void AddObject(Object* obj) override;
     virtual void RemoveObject(Object* obj) override;
 
@@ -93,7 +99,7 @@ signals:
         if (m_InUpdated) return;  // break signal recursion
         m_InUpdated = true;
         this->ComputeBoundingBox();
-        ULIB_SIGNAL_EMIT(Assembly::Updated);
+        ULIB_SIGNAL_EMIT(Object::Updated);
         m_InUpdated = false;
     }
 
@@ -103,6 +109,7 @@ private:
     bool     m_ShowBoundingBox;
     bool     m_GroupSelection;
     bool     m_InUpdated = false;
+    std::map<Object*, Connection> m_ChildConnections;
 };
 
 } // namespace uLib

src/Math/ContainerBox.h

@@ -215,7 +215,7 @@ signals:
   /** Signal emitted when properties change */
   virtual void Updated() override { 
       this->Sync();
-      ULIB_SIGNAL_EMIT(ContainerBox::Updated); 
+      ULIB_SIGNAL_EMIT(Object::Updated); 
   }
 
 private:

src/Math/Cylinder.h

@@ -177,7 +177,7 @@ signals:
     /** Signal emitted when properties change */
     virtual void Updated() override { 
         this->Sync();
-        ULIB_SIGNAL_EMIT(Cylinder::Updated); 
+        ULIB_SIGNAL_EMIT(Object::Updated); 
     }
 
 private:

src/Math/MathRegistrations.cpp

@@ -5,12 +5,14 @@
 #include "Math/TriangleMesh.h"
 #include "Math/QuadMesh.h"
 #include "Math/VoxImage.h"
+#include "Math/Assembly.h"
 #include "Math/StructuredData.h"
 
 namespace uLib {
 
 ULIB_REGISTER_OBJECT(ContainerBox)
 ULIB_REGISTER_OBJECT(Cylinder)
+ULIB_REGISTER_OBJECT(Assembly)
 ULIB_REGISTER_OBJECT(CylindricalGeometry)
 ULIB_REGISTER_OBJECT(SphericalGeometry)
 ULIB_REGISTER_OBJECT(TriangleMesh)

src/Math/Transform.h

@@ -285,7 +285,7 @@ signals:
     /** Signal emitted when properties change */
     virtual void Updated() override { 
         this->Sync();
-        ULIB_SIGNAL_EMIT(AffineTransform::Updated); 
+        ULIB_SIGNAL_EMIT(Object::Updated); 
     }
 
 private: